oasis-open / openc2-lycan-python

OASIS TC Open Repository: A GitHub public repository for development of a python library to transform between data-interchange formats (such as JSON) and python language objects
https://github.com/oasis-open/openc2-lycan-python
Other
11 stars 12 forks source link

Fix for stix2 namespace collision #43

Closed twodayslate closed 4 years ago

twodayslate commented 4 years ago

stix2 recently added a base.py file to v20 which conflicted with the modules base.py file. This caused a failed test case in our module. Thankfully, this proves that our migration away from stix2 in #42 is justified.

This PR also adds an additional test to ensure that _OpenC2Base objects are equatable. I investigated making them hashable as well but since they are mutable this didn't sound like a good idea. I would like to investigate a finalize method to make the object immutable and thus hashable.