search

oasis-open / tosca-community-contributions

OASIS TC Open Repository: Manages TOSCA profiles, tests, and templates that are maintained by the TOSCA community. They are intended to be used as examples to help developers get started with TOSCA and to test compliance of TOSCA implementations with the standard.
https://github.com/oasis-open/tosca-community-contributions
Apache License 2.0
39 stars 25 forks source link

One error in simple-for-nfv.yaml #107

Closed philippemerle closed 2 years ago

philippemerle commented 2 years ago

Issue Description

https://github.com/oasis-open/tosca-community-contributions/blob/master/examples/1.2/simple-for-nfv/simple-for-nfv.yaml provided by @tliron contains one error at https://github.com/oasis-open/tosca-community-contributions/blob/master/examples/1.2/simple-for-nfv/simple-for-nfv.yaml#L19. The virtual_binding requirement is assigned two times as illustrated in the following diagram:

Diagram

But the virtual_binding requirement is defined with the default occurrences [1, 1] at https://github.com/oasis-open/tosca-community-contributions/blob/master/profiles/org.oasis-open/simple-for-nfv/1.0/nodes.yaml#L211.

Proposed Resolution

Split the VduCp node template into two VduCp node templates as illustrated in the following diagram:

examples-1 2-simple-for-nfv-simple-for-nfv-uml2-component-diagram1

tliron commented 2 years ago

Thank you, the examples I provided for this repo are out of date and should be updated. Here is the current version, which is already fixed.

philippemerle commented 2 years ago

@tliron My proposed resolution is coded in https://github.com/oasis-open/tosca-community-contributions/pull/108

lauwers commented 2 years ago

I think we should remove this example as well as the NFV profile. OASIS never released the NFV profile as a standard (we stopped work after CSC04) and the work was taken over by ETSI.