search

oasis-open / tosca-community-contributions

OASIS TC Open Repository: Manages TOSCA profiles, tests, and templates that are maintained by the TOSCA community. They are intended to be used as examples to help developers get started with TOSCA and to test compliance of TOSCA implementations with the standard.
https://github.com/oasis-open/tosca-community-contributions
Apache License 2.0
38 stars 25 forks source link

Rename `entry_schema` and `key_schema` to `entry_type` and `key_type` #125

Open tliron opened 2 years ago

tliron commented 2 years ago

The word "schema" is confusing here, as we are referring to a data type.

Changing it to _type also aligns with my general preference that keynames include the name of entity type of what they refer to.

lauwers commented 2 years ago

I don't believe "type" is the correct type of entity here. Let's assume we have a list of lists. In that case the "entry_schema" is "list". But since "entry_schema" is required for lists, we also need to specify the entry schema for the list type specified in the original entity schema. This means that we may need full parameter definition syntax here, in which case we should consider renaming entry_schema to entry_definition, not entry_type.