oasis-roles / ansible-role-redhat_satellite6_storage

GNU General Public License v3.0
3 stars 1 forks source link

possible rename role for how it shows up in ansible galaxy #3

Open itewk opened 4 years ago

itewk commented 4 years ago

Continuation of conversation from https://github.com/oasis-roles/ansible-role-redhat_satellite6_storage/issues/2#issuecomment-599626055

Suggested new names:

itewk commented 4 years ago

@greg-hellings thoughts? do you all have naming standards? Full product name vs short? include redhat when its a red hat product vs targeted at an upstream that may have the same name?

stdevel commented 4 years ago

My favorite is satellite6_storage - it's short and self-explanatory. :) Another one would be katello_storage - as Foreman/Katello could also be used in a vanilla way.

greg-hellings commented 4 years ago

Any standards we have are in the meta_standards role. Going from memory, our only standards are to have _ instead of - characters. Basically, a role name needs to be a valid Python identifier.

Personally, I would name this role satellite_storage and try to have support for any supported versions of Satellite from this one role. Rather than fix the satellite version into the name, which I don't think gains us much unless we're absolutely certain that we'll never be able to support multiple versions in one role. Once we move it into a collection I would just name it storage and name the whole collection oasis_roles.satellite at that time.

stdevel commented 4 years ago

That's a good idea as Red Hat Satellite 7 is already in rough planning. So satellite_storage now looks also best to me.

itewk commented 4 years ago

@stdevel make it so :)

stdevel commented 4 years ago

PR was created - see also #7

stdevel commented 4 years ago

PR was merged, so the issue can be closed! 🎉