search

oasis-tcs / openc2-oc2ls

OASIS OpenC2 TC: GitHub repository used to propose and track changes to the OpenC2 Language Specification as new working draft level revisions are created and the associated CSDs mature
https://github.com/oasis-tcs/openc2-oc2ls
Other
15 stars 19 forks source link

Process target defined recursively #413

Closed dlemire60 closed 7 months ago

dlemire60 commented 1 year ago

The Process target as currently defined is recursive:

  ["Process", "Map", ["{1"], "", [
    [1, "pid", "Integer", ["[0", "{0"], "Process ID of the process"],
    [2, "name", "String", ["[0"], "Name of the process"],
    [3, "cwd", "String", ["[0"], "Current working directory of the process"],
    [4, "executable", "File", ["[0"], "Executable that was executed to start the process"],
    [5, "parent", "Process", ["[0"], "Process that spawned this one"],
    [6, "command_line", "String", ["[0"], "The full command line invocation used to start this process, including all arguments"]
  ]]

The definition needs to be updated with key/link field options to created a "references" relationship. I believe the pid field can be the key, and the parent field should be a link.

davaya commented 9 months ago

There are two possible fixes: 1) add key/link "extension" options 2) change "parent" type to "pid" type (Integer) as processing the key/link extension would do

I agree that the current definition is recursive and must be fixed, and agree with fix 1).

dlemire60 commented 9 months ago

PR #421 fixes the Process type definition table, however the JADN schema needs to be updated for a proper fix.

dlemire60 commented 7 months ago

This issue is now closed, per consensus at the 10 January 2024 working meeting.