search

oasis-tcs / sarif-spec

OASIS SARIF TC: Repository for development of the draft standard, where requests for modification should be made via Github Issues
https://github.com/oasis-tcs/sarif-spec
Other
166 stars 47 forks source link

3.24.6 roles property has two "NOTE 3"s #634

Closed davidmalcolm closed 2 months ago

davidmalcolm commented 4 months ago

The 3.24.6 roles property (https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/sarif-v2.1.0-errata01-os-complete.html#_Toc141790867) has:

Presumably the last one should be NOTE 4. Visible in both the HTML and PDF.

sthagen commented 4 months ago

Proposal

Rewrite (line https://github.com/oasis-tcs/sarif-spec/blob/main/sarif-2.2/prose/edit/src/file-format-24-artifact-object.md?plain=1#L142):

    NOTE 3: The information conveyed by these values could be extracted from a VCS. These properties exist so SARIF consumers can have this information without needing access to the VCS.

as:

    NOTE 4: The information conveyed by these values could be extracted from a VCS. These properties exist so SARIF consumers can have this information without needing access to the VCS.