oasis-tcs / sarif-spec

OASIS SARIF TC: Repository for development of the draft standard, where requests for modification should be made via Github Issues
https://github.com/oasis-tcs/sarif-spec
Other
169 stars 47 forks source link

sarif 2.1.0 schema url in Schemata stopped working #646

Open jsoref opened 4 months ago

jsoref commented 4 months ago

633 renamed the sarif 2.1.0 schema.

something renamed the default branch from master to main.

I was linking to the file in order to generate my json which enables json validators to be happy... https://github.com/check-spelling/check-spelling/blob/26b46adbdebd5dd0b34c7155113d50c40f43fb22/sarif.json#L2

  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",

The above collective changes have broken that.

There doesn't appear to be any tag that I could use instead. What is the recommended practice for content generators?

Are we supposed to link to a specific sha?

KalleOlaviNiemitalo commented 4 months ago

[SARIF-v2.1.0-Errata01] section 3.13.3 ($schema property) note 2 suggests https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/schemas/sarif-schema-2.1.0.json.

There's also https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/schemas/sarif-schema-2.1.0.json for the version before the errata fixes.

jsoref commented 4 months ago

Fwiw, there are ~3k hits for this url: https://github.com/search?q=%22https%3A%2F%2Fraw.githubusercontent.com%2Foasis-tcs%2Fsarif-spec%2Fmaster%2FSchemata%2Fsarif-schema-2.1.0.json%22&type=code

I'm happy to change my code, but I can't change everyone else's.