search

oasis-tcs / virtio-spec

OASIS Virtual I/O Device TC: Source code for the VIRTIO (Virtual I/O) Specification maintained by the OASIS Virtual I/O Device (VIRTIO) Technical Committee
https://github.com/oasis-tcs/virtio-spec
Other
233 stars 70 forks source link

virtio-net: Clarify the size of virtio_net_hdr for tx, rx along with receive buffer size #183

Open paravmellanox opened 10 months ago

paravmellanox commented 10 months ago

There are few small issues around size of receive buffer and size of the struct virtio_net_hdr as following.

  1. VIRTIO_NET_F_HASH_REPORT is only applicable on the rx side packet processing. However it changes the size of the struct virtio_net_hdr for the tx side as well. This was not clarified when VIRTIO_NET_F_HASH_REPORT feature was introduced.

  2. Receive buffer size calculation description and requirements did not reflect negotiation of VIRTIO_NET_F_HASH_REPORT.

  3. Receive buffer size calculation was incorrect for ipv6 guest gso feature.

Above issue 2 was reported in [1]. Since issue 2 and 3 both touches the same set of requirements and description, they are updated under a new issue along with tx side fix as well touching the clarification needed for VIRTIO_NET_F_HASH_REPORT.

Hence above three issues are fixed under issue of [2]. [1] https://github.com/oasis-tcs/virtio-spec/issues/170 [2] https://github.com/oasis-tcs/virtio-spec/issues/183

Fix: https://lore.kernel.org/virtio-comment/20240606102014.2103986-1-parav@nvidia.com/T/#u

mstsirkin commented 3 months ago

reviewer pointed out that we capitalize MUST. pls fix, post, update link here and we'll vote

paravmellanox commented 3 months ago

fix, reposted, link updated.

mstsirkin commented 3 months ago

BALLOT CREATED AT URL: https://groups.oasis-open.org/higherlogic/ws/public/ballot?id=3833