search

oasis-tcs / xliff-omos-jliff

OASIS XLIFF OMOS TC: JSON serialization of the XLIFF Abstract Object Model
https://github.com/oasis-tcs/xliff-omos-jliff
Other
17 stars 4 forks source link

Review use of xml_lang throughout jliff objects in the prose #18

Open DavidFatDavidF opened 3 years ago

DavidFatDavidF commented 3 years ago

especially in source and target within mtc_

DavidFatDavidF commented 3 years ago

To avoid manual PRs, I will not touch xml lang provisions in attribute and element prose spec files while @genivia-inc is working on them

DavidFatDavidF commented 3 years ago

Try and reuse the solution proposed in #31

DavidFatDavidF commented 3 years ago

Probably create xmlLang on notes. Think about it and discuss again in the April meeting Any other text nodes that we cannot set language information for?

DavidFatDavidF commented 3 years ago

The solution agreed in meeting om 25th May:

create "notesXmlLang" property as sibling of "notes" on "subitem" and "file" create "textXmlLang" property as sibling to "text" on "note"

Robert to implement in schema dF to implement in prose once schema committed

Rationale by design principles:

  1. avoid a notes wrapper
  2. solution structurally the same as for xml:lang on source and target
  3. avoid stating xmlLang on the root object not to confuse with srcLang and trgLang
  4. allow for both inheriting xm:lang values in notes as well as setting note language individually
genivia-inc commented 3 years ago

Schema is updated with the new notesXmlLang and textXmlLang properties.

https://github.com/oasis-tcs/xliff-omos-jliff/commit/b22475630e272176dfca0c11a86c16574f19644e#diff-3c525cc019d712b6a8511e16483ef69ef6676993fc0e4ba3d9cb6ac35e90c829