oasis-tcs / xliff-xliff-22

OASIS XLIFF TC: A repository designed for use in development of TC chartered work products and test suites
https://github.com/oasis-tcs/xliff-xliff-22
Other
10 stars 2 forks source link

XLIFF 2.1 - Example in 4.3.1.40 type is invalid #10

Closed yumaoka closed 2 years ago

yumaoka commented 2 years ago
<segment>
  <source xml:lang="cs"><pc type="quote">Blázen,
      chce dobýt točnu v takovém počasí</pc>, dodal slovy svého
      oblíbeného imaginárního autora.</source>
  <target xml:lang="en"><pc type="quote">Madman, he wants to conquer the
      pole in this weather</pc>, offered he the words of his
      favourite imaginary playwright.</target>
</segment>

The example above illustrates the use of type="quote" with <pc> element. The id attribute is required in each <pc> element, but the example is missing the attribute.

In addition to this, I personally don't like to put xml:lang attribute in this example. I think the original author's intent was to clarify what is source/target language in this example. But even without it, it should be sufficient to illustrate the use of type="quote" with <pc> element.

DavidFatDavidF commented 2 years ago

agreed to add id attributes in the pc elements, I would keep the xml:lang

rmraya commented 2 years ago

Fixed in current draft

DavidFatDavidF commented 2 years ago

Check if the xml:lang was kept