search

oasislabs / web3c.js

A js library for confidential web3 calls
https://oasislabs.com
Other
38 stars 10 forks source link

react-native support #153

Closed armaniferrante closed 5 years ago

willscott commented 5 years ago

is #155 sufficient for this bug?

armaniferrante commented 5 years ago

It's sufficient for the example I've created. However, I'm waiting for sinchan to provide feedback as to whether its sufficient for his purposes, before cutting a new release.

ryscheng commented 5 years ago

You should probably ping him to see if he's actually trying it or waiting for a release

Cheers, Ray

On Sun, Mar 17, 2019, 12:11 Armani Ferrante notifications@github.com wrote:

It's sufficient for the example I've created. However, I'm waiting for sinchan to provide feedback as to whether its sufficient for his purposes, before cutting a new release.

Furthermore, we should I'd like to put the example into CI before closing the issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/oasislabs/web3c.js/issues/153#issuecomment-473705190, or mute the thread https://github.com/notifications/unsubscribe-auth/AAimamiqUOR16Jm5Inr8Kh3RtjLsGNKuks5vXpN0gaJpZM4b0tJ3 .

armaniferrante commented 5 years ago

I told him on Friday that I will not cut a release until he has confirmed the changes are sufficient, and that he should test out master.

willscott commented 5 years ago

We should open source https://github.com/oasislabs/react-native-web3c as the criteria for closing this issue.

Armani: I don't think it's an issue if we release it before we get confirmation from thinkable that all issues are resolved, and would advocate for doing that earlier.

willscott commented 5 years ago

@armaniferrante - any issues with open sourcing and calling this good pending feedback?

armaniferrante commented 5 years ago

No issues, though still waiting for feedback from sinchan. I'm happy to open source react-native-web3c.

armaniferrante commented 5 years ago

Open sourced. Closing.