search

oasisprotocol / cli

Official CLI for the Oasis Network.
Apache License 2.0
12 stars 1 forks source link

docs: Line number requires specified language #240

Closed matevz closed 2 months ago

matevz commented 2 months ago

This is the behavior introduced by https://github.com/oasisprotocol/docs/pull/820. This is also the same as in the official markdown code block.

e.g. This doesn't work

```{2-3}
a
b
c
d

but this does:
a
b
c
d
netlify[bot] commented 2 months ago

Deploy Preview for oasisprotocol-cli ready!

Name Link
Latest commit 0dffbb473288e56f29d087e818e2a47f8870bf40
Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6644816f4ddcec0008826bcf
Deploy Preview https://deploy-preview-240--oasisprotocol-cli.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

matevz commented 2 months ago

Any reason why this changes aren't included in oasisprotocol/docs#820?

You probably meant https://github.com/oasisprotocol/cli/pull/238/files#diff-f47f6c25f8613e21081f4dd5cbbcdd07aaa87b7ebf8898b1ddfbde86cfedd1c5R43 ? Because the initial implementation of ![code {4}](snippet.out) didn't actually work, but my tests used a cached version of the docs and thought it worked when merging it.