search

oasisprotocol / oasis-core

Performant and Confidentiality-Preserving Smart Contracts + Blockchains
https://oasisprotocol.org
Apache License 2.0
332 stars 109 forks source link

go/runtime/txpool: Don't abort runtime if node is not synced yet #5630

Closed abukosek closed 5 months ago

abukosek commented 5 months ago

If the node hasn't finished syncing, checkTxBatch previously caused the runtime to be aborted, even though it wasn't the runtime's fault. Now the checks are retried after the node is finished syncing.

netlify[bot] commented 5 months ago

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
Latest commit e2a869391c367b9d6b4e42850cd125e83ae8fad0
Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/6624dcfb6e3bcf00088cd5e0
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.93%. Comparing base (ffd8c8b) to head (f0dbb0e). Report is 25 commits behind head on master.

:exclamation: Current head f0dbb0e differs from pull request most recent head e2a8693. Consider uploading reports for the commit e2a8693 to get more accurate results

Files Patch % Lines
go/runtime/txpool/txpool.go 90.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5630 +/- ## ========================================== + Coverage 65.26% 65.93% +0.66% ========================================== Files 594 593 -1 Lines 61018 60967 -51 ========================================== + Hits 39825 40197 +372 + Misses 16499 16087 -412 + Partials 4694 4683 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abukosek commented 5 months ago

All review comments have been addressed, so please take another look :)