oasisprotocol / oasis-core

Performant and Confidentiality-Preserving Smart Contracts + Blockchains
https://oasisprotocol.org
Apache License 2.0
338 stars 112 forks source link

go/storage/mkvs/db/pathbadger: Record sequence number early #5635

Closed kostko closed 7 months ago

kostko commented 7 months ago

We need to commit the sequence number for the pending (non-finalized) root early on. Otherwise a crash could result in the root being committed but its sequence number is not known so finalization would fail.

The issue was discovered by our long-term E2E tests.

netlify[bot] commented 7 months ago

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
Latest commit 0b8a1d4b3596be571de7fcc832eeee44fc54b2c1
Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/6616ba5ad36e3c0008a7c04b