search

oasisprotocol / oasis-core

Performant and Confidentiality-Preserving Smart Contracts + Blockchains
https://oasisprotocol.org
Apache License 2.0
338 stars 113 forks source link

extraneous check? also, naming nit. #5905

Open bennetyee opened 1 month ago

bennetyee commented 1 month ago

https://github.com/oasisprotocol/oasis-core/blob/3f241f7f97ca4b7f9f0069b66daf37b28216cd94/secret-sharing/src/churp/dealer.rs#L147

is_zero_ij? in any case, what is the rationale for needing this coefficient to be non-zero? if it is actually needed, a comment explaining why would be useful.

same extraneous check here:

https://github.com/oasisprotocol/oasis-core/blob/6dcf9d8efcc828f8f194df1e82dfe5fe96ad7221/secret-sharing/src/churp/shareholder.rs#L206