search

oasisprotocol / oasis-sdk

Official SDK for the Oasis Network.
Apache License 2.0
72 stars 18 forks source link

Add support for consensus pool:common and pool:fee-accumulator #1508

Closed matevz closed 7 months ago

matevz commented 12 months ago

Currently, only the runtime's common pool and fee accumulator is resolved in https://github.com/oasisprotocol/oasis-sdk/blob/main/client-sdk/go/helpers/address.go. Add support for consensus common pool and fee-accumulator as well by passing the ParaTime instance to ResolveAddress(). If the instance is defined, then use the ParaTime's address, otherwise return the consensus address.

Perhaps it would make sense to migrate most of the helpers/address.go to Oasis CLI and get rid of all the pools, separators and other CLI-related literals?

kostko commented 12 months ago

Yes, I agree that this should be moved to the CLI.