search

oasisprotocol / oasis-sdk

Official SDK for the Oasis Network.
Apache License 2.0
75 stars 21 forks source link

Incorrect error code in @oasisprotocol/client-rt #1938

Open lukaw3d opened 2 months ago

lukaw3d commented 2 months ago

I don't think anyone uses this, so not important in that way. But if this is auto-generated code, then something bigger broke

https://github.com/oasisprotocol/oasis-sdk/blob/5844bfe7d7240a668e9f7209e2a15dbfe417ed4c/client-sdk/ts-web/rt/src/evm.ts#L17-L20

duplicates error code 8

Probably the source of these codes:

https://github.com/oasisprotocol/oasis-sdk/blob/5844bfe7d7240a668e9f7209e2a15dbfe417ed4c/runtime-sdk/modules/evm/src/lib.rs#L150-L165

lukaw3d commented 2 months ago

@pro-wh do you know if this is autogenerated?

pro-wh commented 2 months ago

don't have autogeneration for rust to typescript. gotta update these manually

pro-wh commented 2 months ago

https://github.com/oasisprotocol/oasis-sdk/pull/885/files#diff-2d532440a62d8b10b2fbd905bb4780478360e4ee8446e3a9c127956ab054950fR19

manually :smiling_face_with_tear: