Closed ptrus closed 1 month ago
Name | Link |
---|---|
Latest commit | 885a055e2796a4f89c8d60f6b830fbdab81f2612 |
Latest deploy log | https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/670f6fbbe4f8d7000889a604 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.63%. Comparing base (
182b1b3
) to head (a6cca06
). Report is 17 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please check again, I updated it a bit to be in line with the gRPC address spec defined at: https://github.com/grpc/grpc/blob/master/doc/naming.md
Updated code once again, now it reuses the method from oasis-core (added in: https://github.com/oasisprotocol/oasis-core/pull/5878)
Yes, but if we don't plan to release it anytime soon, then we could copy the method for now.
But we will need to release the updated oasis-sdk
and oasis-cli
anyway if we want a working cli
with the localnet container, so we could wait for oasis-core
as well if there are any plans for it in the near future.
@matevz not sure how urgently we want this for different components
oasis-cli
to work with localnet - we need oasis-sdk
and oasis-cli
releases (and potentially oasis-core
unless we duplicate the code here)oasis-node
to work with localnet - we need oasis-core
releaseSure, we can wait for the point release of the oasis-core
and keep a clean code here.
Oasis Core 24.3 has been released, please rebase, then we can tag the Go Client SDK.
This usecase came up in https://github.com/oasisprotocol/oasis-web3-gateway/pull/626 since we want to expose the node from docker via a port (since this works better cross-platform than exposing the socket via a volume).
The alternative possible solution would be to provide a flag that allows insecure connections or connections with self-signed certs (something like --insecure in curl).
BTW we might want to do the same in oasis-core: https://github.com/oasisprotocol/oasis-core/blob/280d2ef1947bc9baaeb390c3131a08b87824c9ef/go/oasis-node/cmd/common/grpc/grpc.go#L83-L89 since ideally, both
oasis-node
andoasis-cli
would work with local-net without much hassle.cc @matevz
TODO: