Fix connecting to ledger by opening a normal window, not headless popup

oasisprotocol / oasis-wallet-ext

The official non-custodial browser extension wallet for the Oasis Network.

https://chrome.google.com/webstore/detail/oasis-wallet/ppdadbejkmjnefldpcdjhnkpbjkikoip

Apache License 2.0

30 stars 16 forks source link

Fix connecting to ledger by opening a normal window, not headless popup #302

Closed lukaw3d closed 1 year ago

lukaw3d commented 1 year ago

Alternative to https://github.com/oasisprotocol/oasis-wallet-ext/pull/301: Chrome updates broke asking for USB permissions inside popups

Before	After

buberdds commented 1 year ago

I like it better than #301 because popup stays open (even if a new window with all UI elements look crappy). edit: ah user can still close popup by accident

lukaw3d commented 1 year ago

Don voted https://github.com/oasisprotocol/oasis-wallet-ext/pull/301