Fix opening popup (error "Bounds must be at least 50% within visible screen space")

oasisprotocol / oasis-wallet-ext

The official non-custodial browser extension wallet for the Oasis Network.

https://chrome.google.com/webstore/detail/oasis-wallet/ppdadbejkmjnefldpcdjhnkpbjkikoip

Apache License 2.0

30 stars 16 forks source link

Fix opening popup (error "Bounds must be at least 50% within visible screen space") #317

Closed lukaw3d closed 11 months ago

lukaw3d commented 1 year ago

If user freshly installs extension, opens popup, closes it, opens popup:

popup initializes very quickly
window.screenLeft in openCurrentRouteInPersistentPopup returns extension's icon position (instead of popup) near the edge of the screen
Chrome blocks popup "Bounds must be at least 50% within visible screen space"
user can't open the popup

This only happens with production build. In development build javascript is loaded slower, and window.screenLeft returns popup position.

matevz commented 1 year ago

I downgraded node to v14 to match github actions, but I'm still getting

$ yarn buildProd
yarn run v1.22.5
$ env NODE_OPTIONS=--openssl-legacy-provider webpack --mode production
/home/oa/node-v14.17.0-linux-x64/bin/node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
error Command failed with exit code 9.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any ideas?

lukaw3d commented 1 year ago

Hm I think openssl-legacy-provider is needed on node >=18, and CI on this project is bad