oasisprotocol / oasis-wallet-ext

The official non-custodial browser extension wallet for the Oasis Network.
https://chrome.google.com/webstore/detail/oasis-wallet/ppdadbejkmjnefldpcdjhnkpbjkikoip
Apache License 2.0
30 stars 16 forks source link

Increased linting #49

Open aefhm opened 3 years ago

aefhm commented 3 years ago

(non-blocking)

I think we can increase the tooling and tighten up whitespace linting and prefix variable names with _ when unused.

Some boolean expressions will then also be more clear too.

pro-wh commented 3 years ago

Some recommendations: prettier, eslint. We have an eslint config in our web wallet repo, which might be a good starting point

nhynes commented 2 years ago

Any update on this? Prettier really is quite useful. Eslint, too. I like format-on-save with Prettier. It lets me focus on the code instead of typing correctly,.

pro-wh commented 2 years ago

there's just always been large projects ongoing. I think the latest is #185 and #200 for switching the build system to parcel