search

oasisprotocol / oasis-web3-gateway

Web3 Gateway for the Oasis SDK EVM ParaTime module.
GNU General Public License v3.0
27 stars 14 forks source link

Versioned Release tags for sapphire-dev container #417

Open CedarMist opened 1 year ago

CedarMist commented 1 year ago
SUMMARY

The sapphire-dev container latest tag will pull an image with whatever the most recent commits are.

If I'm targeting sapphire-dev:latest do I expect to get the latest stable version.

Is it worth the hassle to maintain tagged releases of the docker container for each test & stable release. Maybe another branch for latest-test which is equivalent to latest when it becomes stable.

Suggested tags:

kostko commented 1 year ago

We could in addition tag based on the PARATIME_VERSION field specified in the Dockerfile? So we would get things like sapphire-dev:0.6.1-testnet in addition to the above automatic tags in case someone wants to test a specific runtime version.

CedarMist commented 1 year ago

So, to summarise:

https://github.com/oasisprotocol/oasis-web3-gateway/blob/5f35bffeace30b751c676089f4f2a7688d58bb57/.github/workflows/docker-dev.yml#L42-L49

Extract PARATIME_VERSION from container and add an additional tag. These won't be pruned as they're not prefixed with latest-.

Will see how to get the PARATIME_VERSION param, and add to #420 if it's a quick addition.