oasisprotocol / sapphire-paratime

Oasis Sapphire - the confidential EVM-compatible ParaTime for the Oasis Network
https://oasisprotocol.org/sapphire
Apache License 2.0
35 stars 26 forks source link

clients/go: Bump oasis-core to 23.0 #278

Closed matevz closed 6 months ago

matevz commented 6 months ago

This PR:

netlify[bot] commented 6 months ago

Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
Latest commit b615766cfa39e9f7b233cd0cff6eed061952af6d
Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/65eae49b5d9c2d000834118f
kostko commented 6 months ago

This current API seems confusing and error-prone. It looks like it has two hooks to manipulate transactions:

I think it would be better if SendTransaction was not overriden and in case you want encrypted transactions you either need to encrypt them manually or use the Transactor.

aefhm commented 6 months ago

I suppose this'll effect a minor version bump?