search

oasisprotocol / sapphire-paratime

The Sapphire ParaTime monorepo.
https://oasisprotocol.org/sapphire
Apache License 2.0
34 stars 24 forks source link

Fix Go client contract deployment #315

Closed aefhm closed 3 months ago

aefhm commented 3 months ago

Description

PackSignedCall is part of the deployment flow and needs to support the case where msg.To is nil.

https://github.com/oasisprotocol/sapphire-paratime/blob/5d6b79e859283f4d707fa41015f33b94dffb78dd/clients/go/compat.go#L90-L97

TODO

netlify[bot] commented 3 months ago

Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name Link
Latest commit 7ed30b52a0959999d8feb56a119d27883e0faebb
Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66466fd6d22d55000880dbea
Deploy Preview https://deploy-preview-315--oasisprotocol-sapphire-paratime.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aefhm commented 3 months ago

The app crashes when you want to deploy a contract with an encrypted transaction right?

I'm using plain. 🤔

probably because we use the unwrapped version of the eth client for the contract deployment.

Which version of the client?

aefhm commented 3 months ago

I think my QA issues are independent of this client patch.

aefhm commented 3 months ago

@kostko new release to clients/go/v0.11.2 please?

kostko commented 3 months ago

Done.