search

oasisprotocol / sapphire-paratime

Oasis Sapphire - the confidential EVM-compatible ParaTime for the Oasis Network
https://oasisprotocol.org/sapphire
Apache License 2.0
35 stars 26 forks source link

docs: Update quickstart code references #359

Closed aefhm closed 1 week ago

aefhm commented 3 weeks ago

Description

After Viem and Wagmi V2 changes in https://github.com/oasisprotocol/sapphire-paratime/pull/303, some code examples are out of date. Closes https://github.com/oasisprotocol/sapphire-paratime/issues/351

netlify[bot] commented 3 weeks ago

Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name Link
Latest commit c6c3fc2af836da15884498dea32ab55b10791d6c
Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66d525c4140afd000804781e
Deploy Preview https://deploy-preview-359--oasisprotocol-sapphire-paratime.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

matevz commented 2 weeks ago

Instead of using commit hashes, should we make the clients/js/stable/1.x branch instead? This is also useful, if we needed to backport anything until 2.x is stable.

aefhm commented 2 weeks ago

Instead of using commit hashes, should we make the clients/js/stable/1.x branch instead? This is also useful, if we needed to backport anything until 2.x is stable.

In which case, I think we would branch off this commit? I think main is quite a bit ahead by now. Would this slightly more readable alternative (than just a commit SHA) be reasonable?

aefhm commented 1 week ago

Superceded by https://github.com/oasisprotocol/sapphire-paratime/pull/378