oasisprotocol / sapphire-paratime

Oasis Sapphire - the confidential EVM-compatible ParaTime for the Oasis Network
https://oasisprotocol.org/sapphire
Apache License 2.0
39 stars 27 forks source link

packaging: remove semver tags from package versions #388

Closed CedarMist closed 2 months ago

CedarMist commented 2 months ago

So, need to re-release packages to get versioning working correctly.

So, we're going to archive:

Then release @oasisprotocol/sapphire-paratime v2.0.0 on the next tag

The sapphire-viem-v2, sapphire-ethers-v6, sapphire-hardhat and sapphire-wagmi-v2 packages will be published on their own latest tags.

Meaning people who npm install @oasisprotocol/sapphire-paratime will get v1.x by default, but if you install @oasisprotocol/sapphire-ethers-v6 you'll get @oasisprotocol/sapphire-paratime v2 as a dependency.

This means we'll be tagging clients/js/v2.0.0-next (to publish to the next dist-tag on NPMJS), but integrations/ethers-v6/v6.0.0 (to publish to latest).

Version resolution for dependencies on package.json will ignore the dist-tags, but adhere to any semver rules.

netlify[bot] commented 2 months ago

Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
Latest commit 6ea04d7d26fbcf30e9fb8c7c306db2ad15f6c352
Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66e6094c994b0a00087665c8
CedarMist commented 2 months ago

So quick point of thought, currently sapphire-hardhat is 2.22.2-next.0

If I do pnpm upgrade and v2.22.2 is in the next dist-tag, this will upgrade to that version, but if -next is used as a semver tag it won't.

So, I think we should keep sapphire-hardhat semver tag as next, and release on dist-tag next.

aefhm commented 2 months ago

If I do pnpm upgrade and v2.22.2 is in the next dist-tag, this will upgrade to that version, but if -next is used as a semver tag it won't.

Isn't this the desired behavior? 🤔

So, I think we should keep sapphire-hardhat semver tag as next, and release on dist-tag next.

Just checking, you are suggesting we keep it on -next?

CedarMist commented 2 months ago

Release checklist:


Have skipped these as unnecessary