Manifest v3 notes - Githubissues

oasisprotocol / wallet

Official non-custodial wallet for the Oasis Network.

https://wallet.oasis.io

Apache License 2.0

110 stars 45 forks source link

Manifest v3 notes #1168

Open lukaw3d opened 1 year ago

lukaw3d commented 1 year ago

Updated timeline:

Jan 2023: may turn off MV2 extensions in Chrome Beta
Jun 2023: MV2 extensions unlisted, may turn off MV2 extensions
Jan 2024: no more updates to MV2 extensions

TODO

can redux + saga even continue to work despite terminations
fork webext-redux https://github.com/oasisprotocol/oasis-wallet-web/issues/1052
keep wallet unlocked between terminations by storing encryption key in browser.storage.session
check how badly ledger breaks if user waits a minute before confirming a transaction (service worker terminates after 30 seconds?)
https://chromestatus.com/feature/5200265459269632 webusb doesn't even work in MV3 service worker yet
Opening extension as a new tab and storing state in it would solve some of these

lukaw3d commented 1 year ago

Further delayed? https://groups.google.com/a/chromium.org/g/chromium-extensions/c/zQ77HkGmK9E

lukaw3d commented 1 year ago

There's a new update in https://groups.google.com/u/1/a/chromium.org/g/chromium-extensions/c/zQ77HkGmK9E

lukaw3d commented 11 months ago

https://developer.chrome.com/docs/extensions/migrating/mv2-sunset/

Disabling MV2 in Dev, Canary, and Beta as early as June 2024
June 2024 + 1-X months: Chrome MV2 deprecation

Brave says they'll continue supporting MV2

lukaw3d commented 5 months ago

https://bitwarden.com/blog/bitwarden-manifest-v3/

pro-wh commented 5 months ago

key point from bitwarden's article:

https://developer.chrome.com/docs/extensions/reference/api/storage#property-session

new "session" storage area is where to put "in memory" keys. in their case, a key that encrypts a locally-encrypted copy of the vault persisted in localStorage

lukaw3d commented 5 months ago

If we don't plan to have dapp support (https://github.com/oasisprotocol/oasis-wallet-web/issues/1901) then we could:

move redux from background page into popup
store derived keyWithSalt in chrome.storage.session
remove background page / service worker
remove webext-redux

(So ext will behave more like webapp tabs. At some point we aspired the opposite: webapp tabs to use a shared worker to behave more like extension)

pro-wh commented 4 months ago

not aware of anyone using dapp support

https://www.npmjs.com/package/@oasisprotocol/client-ext-utils

apparently this package has 3 downloads weekly though

buberdds commented 3 months ago

https://github.com/tshaddix/webext-redux/releases/tag/v3.0.0