oasisprotocol / wallet

Official non-custodial wallet for the Oasis Network.
https://wallet.oasis.io
Apache License 2.0
110 stars 45 forks source link

Explore manifest v3 with webext-redux v4 #2088

Open buberdds opened 2 weeks ago

buberdds commented 1 week ago

After quick prototyping https://github.com/oasisprotocol/wallet/compare/mz/manifest-v3?expand=1 this can "work". Tested with Ledger too.

Build problems

We can't use dynamic imports in service workers which affects dump validators fallback and dynamic webextension-polyfill imports, but these are easy fixes. The same problem occurs within our @oasisprotocol/ionic-ledger-hw-transport-bl package too. I did not look into details.

Runtime problems

Direct usage of window or document. In most cases this is related to localStorage usage. Maybe we could have utils to switch between chrome.storage and window.localStorage based on build type.