Persist state

[lukaw3d]

Add an option to keep imported accounts in password-encrypted localStorage

Currently user loses all state on reload.

Make sure stored information is also migrate-able from existing extension https://github.com/oasisprotocol/oasis-wallet-ext/blob/e6998cff910449fd0f33fc998d9c5e306d59aa99/src/background/service/APIService.js#L177-L189

[lukaw3d]

Proof of concept https://github.com/oasisprotocol/wallet-poc/pull/1

[lukaw3d]

Main issues with proof of concept - storing and syncing whole redux state:

• it stores fatal error
• syncing multiple tabs conflicts with cleanup, e.g. clearAccount open account in two tabs http://localhost:3000/account/oasis1qzwl8nn8lt8cv4gxh85skv9rw3h0raudws66q4y5 navigate to home on one tab (dispatches clearAccount) other tab loses data and shows loading

[lukaw3d]

Instead of persisting and syncing everything, we should be more selective.

Current state, by longterm-ness

• theme, network, wallet, account, dapp (soon)
• create tx, create wallet, import ledger, stake
• fatalError

We definitely need to store: theme, network (partially), wallet, selected account, dapp (soon) and we definitely shouldn't store and sync: fatalError.

More considerations:

• [x] If user changes password: different selections on tabs might get lost? Don't care.
• [x] selected network needs to be synced as long as network-specific balance is in state.wallets[*].balance

Defer/ignore:

• [ ] Remove fatalError from redux?
• [ ] Ext: To avoid conflicts in "create tx": only allow one popup? or sync exactly?
• [ ] Remove account ID from URL to have simpler state? But then having two tabs is useless, unless we don't sync selected account ID. Maybe support old URLs still, but only show readonly state?

So

nomnoml diagram source

[lukaw3d]

Updated

nomnoml diagram source

[lukaw3d]

Deferred out of https://github.com/oasisprotocol/oasis-wallet-web/pull/975

• [x] test syncing tabs
• [ ] auto lock timeout
• [x] migrate domain: wallet.oasisprotocol.org -> wallet.oasis.io
• [ ] password rules https://github.com/oasisprotocol/oasis-wallet-web/pull/975#issuecomment-1277373366
• [ ] stop auto-redirecting to active wallet on load
  • https://github.com/oasisprotocol/oasis-wallet-web/pull/975#issuecomment-1287225424
  • https://github.com/oasisprotocol/oasis-wallet-web/issues/823
• [x] Validate 50ms timeout for thereAreNoOtherTabs is sufficient
  • https://github.com/oasisprotocol/oasis-wallet-web/commit/50002a4b58d79fafab947c7c36dab519bb0ece98
  • https://github.com/oasisprotocol/oasis-wallet-web/pull/975#discussion_r1012328608
  • It was not sufficient: https://github.com/oasisprotocol/oasis-wallet-web/pull/1343
• [x] Improve delete confirmation UI https://github.com/oasisprotocol/oasis-wallet-web/commit/2175670eacd1dcd56afb4fb50b464b53c5872708
• [ ] multiple profiles

Extension:

• [x] migrate old storage @metamask/browser-passworder and warn users about not storing mnemonic anymore
• [ ] Improve UX of locking in another tab. Especially to support it in extension
  • https://github.com/oasisprotocol/oasis-wallet-web/pull/975#issuecomment-1287565222
  • https://github.com/oasisprotocol/oasis-wallet-web/commit/0fa55341f16dede5f25ef12955161fd38bba30bb