search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Open reviews in code #484

Open sroeger opened 7 years ago

sroeger commented 7 years ago

This issue summarizes java tasks from the code. Actually there are two reviews left:

REVIEW arturk88 (hohwille) we need to find another way to stream the blob without loading into heap.

and

REVIEW may-bee (hohwille) We have a centralized and custom-configured object mapper as spring bean. IMHO we should inject that instance here.

In order to clean up the code those Java Tasks will be removed from the code.

hohwille commented 6 years ago

I checked the first issue because restaurant is a dead-end that will be deleted soon. The second one could either be solved by just removing the comment (there are only 2 properties mapped so actually no issue) or by just injecting the object mapper.

hohwille commented 5 years ago

Injecting the mapper would create an unnecessary dependency from security to rest. Why doing that and also getting in danger of undersired side-effects? Also the question is if that class may also be deleted in the future...