search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

changes in oasp4j pom.xml and template server pom.xml #492

Closed PriyankaBelorkar closed 8 years ago

PriyankaBelorkar commented 8 years ago

While setting up Devonfw first time if we import "workspaces/examples/oasp4j/samples” projects as maven projects in eclipse, it gives build error as "Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-antrun-plugin:1.7:run (execution: copy-sources, phase: compile)".This same error occurs for flatten maven plugin. To resolve this, both the plugins are enclosed within pluginManagement tag in oasp4j pom.xml and oasp4j-template-server pom.xml.

oasp-ci commented 8 years ago

Can one of the admins verify this patch?

hohwille commented 8 years ago

Something is wrong with your IDE setup or the devonfw release is somehow broken. Solution for your problem was done here: https://github.com/oasp/oasp4j-ide/issues/39

Please check your IDE settings (Maven > Lifecycle Mappings > Change mapping file location).

jomora commented 8 years ago

@PriyankaBelorkar I was not able to reproduce the problem.

Which IDE are you using? DEVON or OASP IDE?

hohwille commented 8 years ago

https://github.com/oasp/oasp4j-ide/blob/master/oasp4j-ide-settings/src/main/settings/eclipse/lifecycle-mapping-metadata.xml

hohwille commented 8 years ago

If we have further feedback we can check if some release was messed and create a fixed release. However from my understanding we will reject this PR as this is not the proper fix to your actual problem.

hohwille commented 8 years ago

Please give us feedback or we have to close without any change/improvement.

PriyankaBelorkar commented 8 years ago

Hi all, We found this issue in all the distribution zips Devon fw 2.0.0 and 2.0.1 too and oasp ide versions too.This issue was not only on my machine but others in India team too.

Regards, Priyanka On 22 Sep 2016 20:59, "Jörg Hohwiller" notifications@github.com wrote:

Please give us feedback or we have to close without any change/improvement.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oasp/oasp4j/pull/492#issuecomment-248938075, or mute the thread https://github.com/notifications/unsubscribe-auth/ARJTbW7S687_W5PeaR0ADd_EveU3A5B7ks5qsp7bgaJpZM4KCwcP .

PriyankaBelorkar commented 8 years ago

@hohwille ,@jomora Hi, We found this issue in all distribution zips DEvon 2.0.1 and 2.0.0 and in OASP versions too.Issue not only faced by me but many of others also in India too. Hence the pull request.

Regards, Priyanka

jomora commented 8 years ago

@PriyankaBelorkar which of the following distributions did you use?

I was not able to reproduce your problem using oasp4j-ide-all-2.0.0.zip. However, if you try to import the samples project only (including its subprojects) be sure that either

Otherwise you will face build errors due to different values of the maven parameter oas4j.version.

PriyankaBelorkar commented 8 years ago

Hi Jonas, Please find below steps I did: 1) download and extract oasp4j-ide-all-2.0.0 . 2) Clone oasp4j code from https://github.com/oasp/oasp4j.git 3) reset to latest stable release. 4)imported all oasp4j projects into eclipse. Please find screenshot of the error. errorbuild.png https://drive.google.com/file/d/0B_mRsiHHztAoSm9kdUMydTRIdF9DazNvckNkdGNYUWU0RFJr/view?usp=drivesdk errorbuild1.png https://drive.google.com/file/d/0B_mRsiHHztAoMUZEckt6RFJ3eWttRmdwbXdBaTMwUFJYVzBJ/view?usp=drivesdk

Let me know if you need any more inputs.

Regards, Priyanka On 27 Sep 2016 14:18, "Jonas Molina Ramirez" notifications@github.com wrote:

@PriyankaBelorkar https://github.com/PriyankaBelorkar which of the following distributions did you use?

I was not able to reproduce your problem using oasp4j-ide-all-2.0.0.zip. However, if you try to import the samples project only (including its subprojects) be sure that either

Otherwise you will face build errors due to different values of the maven parameter oas4j.version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oasp/oasp4j/pull/492#issuecomment-249804545, or mute the thread https://github.com/notifications/unsubscribe-auth/ARJTbdu6DSdKrXFKB3eaZHztMVXEUwmnks5quNhagaJpZM4KCwcP .

jomora commented 8 years ago

@PriyankaBelorkar finally I was able to reproduce the error.

The problem occurrs on my machine if I skip step 4) of the IDE setup guide. In your description of your IDE setup you seem to skip this step aswell.

The problem can be fixed by creating the file $projectLoc\variables-customized.bat with the content 

set SETTINGS_REL_PATH=oasp4j\oasp4j-ide\oasp4j-ide-settings\src\main\settings

and then running the scripts create-or-update-workspace.bat and update-all-workspaces.bat. The following picture shows where to locate the file. 2016_09_27_13_12_45_test2

After following these steps, restart your IDE and everything should work. It might be possible that you have to press Ctrl + F5 to update the maven project.

Please let me know if this solution works for you.

Cheers!

PriyankaBelorkar commented 8 years ago

Hi Jonas, I tried to execute steps mentioned by you.. For me the problem is, after creation of variables - customized . bat , when I try to execute update- all - workspaces. bat, black screen just flashes and goes away.. Conf folder gets created but eclipse - main.bat is not created. If I give settings path as settings folder in dist, in variables - customised. bat,I get all the scripts .but when I import projects ..same life cycle mapping issue occurs. Regards, Priyanka On 27 Sep 2016 16:46, "Jonas Molina Ramirez" notifications@github.com wrote:

@PriyankaBelorkar https://github.com/PriyankaBelorkar finally I was able to reproduce the error.

The problem occurrs on my machine if I skip step 4) of the IDE setup guide https://github.com/oasp/oasp4j/wiki/oasp-ide-setup. In your description of your IDE setup you seem to skip this step aswell.

The problem can be fixed by creating the file $projectLoc\variables- customized.bat with the content

set SETTINGS_REL_PATH=oasp4j\oasp4j-ide\oasp4j-ide-settings\src\main\settings

and then running the scripts create-or-update-workspace.bat and update-all-workspaces.bat. The following picture shows where to locate the file. [image: 2016_09_27_13_12_45_test2] https://cloud.githubusercontent.com/assets/5971366/18871131/40b0faf2-84b4-11e6-91cd-5d66575cb654.png

After following these steps, restart your IDE and everything should work. It might be possible that you have to press Ctrl + F5 to update the maven project.

Please let me know if this solution works for you.

Cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oasp/oasp4j/pull/492#issuecomment-249836403, or mute the thread https://github.com/notifications/unsubscribe-auth/ARJTbXZ7EoLdR6Y05BiGtS7KQ6PyhPhLks5quPr-gaJpZM4KCwcP .

PriyankaBelorkar commented 8 years ago

@jomora Hi Jonas, I tried it another time, and yes it works .No errors this time. Earlier I was not able to do a proper clone due to some reasons. Now my question is, 1)For devon dist, we provide examples directory with sample projects, so we have oasp4j project already there.In that case, do we need to make a check out again? 2) Whatever content is there in settings folder in path "oasp4j\oasp4j-ide\oasp4j-ide-settings\src\main\settings", cant we get that content in settings folder of distribution zip, so that no need of creating variables-customized.bat? Please correct me if I am wrong.. Thanks and Regards, Priyanka.

jomora commented 8 years ago

@PriyankaBelorkar good to hear that it works out finally :)

Please, what do you mean by "check out"?

I will now close this PR since it is invalid.

Please, file a new issue with the questions you asked in your last comment. Also, it would be helpful if you could provide more information on question 1) (as I asked at the top of this comment :-)).

Cheers!

PriyankaBelorkar commented 8 years ago

@jomora By checkout I mean, git clone.

hohwille commented 8 years ago

We should check devon distribution zip. I never used it yet. I guess it is broken or @PriyankaBelorkar simply started eclipse manually via software/eclipse/eclipse.exe without reading the steps to follow.

PriyankaBelorkar commented 8 years ago

Hi , I did not start eclipse manually.. I just did not make variables - customized.bat. On 29 Sep 2016 19:52, "Jörg Hohwiller" notifications@github.com wrote:

We should check devon distribution zip. I never used it yet. I guess it is broken or @PriyankaBelorkar https://github.com/PriyankaBelorkar simply started eclipse manually via software/eclipse/eclipse.exe without reading the steps to follow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oasp/oasp4j/pull/492#issuecomment-250480738, or mute the thread https://github.com/notifications/unsubscribe-auth/ARJTbSwyg2paDu5QjTHidQYbwDDES55Kks5qu8m3gaJpZM4KCwcP .

hohwille commented 8 years ago

But devon.zip should already contain variables-customized.bat with proper values as it also comes with code and settings so it makes no sense that this is omitted. We can not include variables-customized.bat in oasp4j-ide as it is project specific, though.

PriyankaBelorkar commented 8 years ago

Hi @hohwille , Thanks for your reply. Well, as per your comment ,I checked previous versions like 1.0.0(contains variables-customized.bat), 2.0.0(does not contain variables-customized.bat).Was it removed intently? And I checked oasp4j code present in examples directory of devon dist , it does contain oasp4j-ide folder, but that is blank, no content in it? Should oasp4j-ide contain all folders like shown in pic? ss. Can you please elaborate ,your last statement that

We can not include variables-customized.bat in oasp4j-ide as it is project specific,

though."

??

PriyankaBelorkar commented 8 years ago

@hohwille can you please reply to my queries above?

hohwille commented 8 years ago

@PriyankaBelorkar you did not follow the instructions: https://github.com/oasp/oasp4j/wiki/oasp-ide-setup You need to clone the repository recursive as oasp4j-ide is a submodule that needs to be cloned as well. Please consult git documentation about submodules for further details.

Was it removed intently?

I guess not and it was a mistake. Ask the devon team responsible for creating this. I am not involved in this activities. In oasp4j-ide this file is intentionally not included as it provides a generic solution to be used by any project. Devon should ship variables-customized.bat with the proper settings for devon.