oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

CLI: stop reinvent the wheel #494

Closed hohwille closed 6 years ago

hohwille commented 8 years ago

During review of #480 I discovered that we have implemented our own CLI in SpringBootBatchCommandLine. In OASP we do not want to reinvent the wheel. We should use an open-source CLI library instead:

Should be discussed with community. Might also relate to Devcon.

hohwille commented 6 years ago

https://github.com/oasp/oasp4j/blob/develop/modules/batch/src/main/java/io/oasp/module/batch/common/base/SpringBootBatchCommandLine.java#L68 Still present in restaurant sample but that is a dead-end and will be deleted anyhow. With MTS this seems not to be the case anymore: https://github.com/oasp/my-thai-star/blob/develop/java/mtsj/core/src/main/java/io/oasp/application/mtsj/SpringBootBatchApp.java#L24 So we properly utilized spring-boot for that.

Therefore I am closing this issue as wontfix as we will not fix something that we are going to delete a feew month later.