search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Prefix All abstract classes with Abstract in the name #561

Closed kiran-vadla closed 7 years ago

kiran-vadla commented 7 years ago

This PR will address the the task of Prefixing all abstract classes with Abstract in the name .

jomora commented 7 years ago

@kiran-vadla I'm not sure whether this is a reasonable task. For example, in #550 @hohwille states

However not every abstract class shall be named with an Abstract prefix. This is not done consistently by jdk, nor by spring, etc.

So, in general not every abstract class needs this prefix. @hohwille gives an example for such classes:

We are already offering classes such as ModuleTest or ComponentTest that are also abstract but do not carry this prefix. So I do not see a problem here.

I think we should not take the discussion regarding #550 (also in Yammer) to change everything that is already in place.

amarinso commented 7 years ago

Why not? it is not done consistently in other projects... but we may prefer to be a bit more consistent here if we have the chance...

As I stated, I prefer to look for clases prefixed with Abstract when in the IDE, for example starting a new test I can extend AbstractTest (ctrl+space) to get help

image

(note here I've already renamed the classes to have the prefix and they are shown nicely together)

jomora commented 7 years ago

@amarinso I got it! :-) Thanks for the clarification!

@kiran-vadla Let's do this! :-)

amarinso commented 7 years ago

Close this as the PR was merged