search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

WebConfig.java has a dependency with catalina (tomcat) for SetCharacterEncodingFilter #577

Closed amarinso closed 7 years ago

amarinso commented 7 years ago

When trying to deploy without Tomcat dependencies this class refuses to compile and is because the direct dependency with org.apache.catalina.filters.SetCharacterEncodingFilter on tomcat-embed-core-xx.jar

kiran-vadla commented 7 years ago

Hi @amarinso , I will be addressing this issue as part of the PR #576

Thanks, @kiran-vadla

kiran-vadla commented 7 years ago

Hi @amarinso , I have submitted the fix as part of PR #576. Please check.

Thanks, @kiran-vadla

amarinso commented 7 years ago

As commented there, it should be on their own PR because it does not make sense to add in an non-related PR

kiran-vadla commented 7 years ago

Hi @amarinso , I have addressed this issue in a separate PR #581 . Please review the same.

amarinso commented 7 years ago

Solved by Kiran for 2.4.0