oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Duplicate AdvancedRevisionEntity breaks jpa-envers module #595

Closed maybeec closed 7 years ago

maybeec commented 7 years ago

This bug is breaking the 2.4.0 release!

Currently there are two classes of AdvancedRevisionEntity: https://github.com/oasp/oasp4j/blob/20b2865a7ce6712fad198e264d71c605a371beaf/modules/jpa-envers/src/main/java/io/oasp/module/jpa/dataaccess/api/common/AdvancedRevisionEntity.java https://github.com/oasp/oasp4j/blob/20b2865a7ce6712fad198e264d71c605a371beaf/modules/jpa-envers/src/main/java/io/oasp/module/jpa/dataaccess/api/AdvancedRevisionEntity.java

maybeec commented 7 years ago

closed in favor of #596

hohwille commented 7 years ago

See also #596 In case we introduce anything new (new package) we should also consider JDK9 and Jigsaw that will prevent us from split packages what we are currently doing in oasp4j-jpa and oasp4j-jpa-envers. Otherwise ignore this and we will have to take care when JDK9 module support comes into play (if ever).