search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

What is the reason for DatabaseMigrator and BeansJpaConfig #605

Closed geoffroya closed 6 years ago

geoffroya commented 6 years ago

Hi all,

Can someone explain the rationale for having DatabaseMigrator and BeansJpaConfig, instead of just overriding FlywayMigrationStrategy?

Best regards

Geoff.

hohwille commented 6 years ago

Link: https://github.com/oasp/oasp4j/blob/master/samples/core/src/test/java/io/oasp/gastronomy/restaurant/general/dataaccess/impl/config/BeansJpaConfig.java#L18

IMHO there is no good reason for this. However, restaurant sample is kind of a dead-end. We have my-thai-star (MTS) in place as a reasonable successor. In 2018 we will delete the restaurant sample and entirely go for MTS as our new sample and reference. Hence, I will close this as polishing a dead project is pointless. Thanks for your feedback and I agree with you but better give feedback and enhancement suggestions about MTS instead: https://github.com/oasp/my-thai-star

geoffroya commented 6 years ago

@hohwille => Actually they are part of the Archetype. I duplicate this to MTS as these classes still exist. IMHO FlywayMigrationStrategy is the good practice for Flyway, no?