search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Eclipse maven template oasp4j-template-server version 2.4.0 produces pom with missing dependency spring-boot-starter-jdbc #613

Closed Jan-PeterRichterCG closed 6 years ago

Jan-PeterRichterCG commented 6 years ago

When you create a new OASP4J using the template io.oasp.java.templates/oasp4j-template-server version 2.4.0 as found on https://repo1.maven.org/maven2 the pom of the xxx-core project does not contain the following dependency:

<dependency>
  <groupId>org.springframework.boot</groupId>
  <artifactId>spring-boot-starter-jdbc</artifactId>
</dependency>

This dependency is needed (at least) to make the H2 database work in file mode (see https://stackoverflow.com/questions/37903105/how-to-configure-spring-boot-to-use-file-based-h2-database discussion of answer 14)

Use of H2 in file mode is not explicitly described in src/main/resources/config/app/application.properties but there is a file application-h2file.properties. That file, however is useless without the above mentioned dependency. Also, the file application-h2mem.properties may be useless [have not tested].

Without the dependency these files / the configurations therein are (for whatever reason) not evaluated.

hohwille commented 6 years ago

Thanks for the feedback. See also #608 so absolutely makes sense. IMHO we just missed 2.5.0 - pitty. Will flag for 3.0.0. Should be trivial to fix.

hohwille commented 6 years ago

Was resolved with #629 that has been merged. The new archetype version 2.6.0 will therefore not have the stated problem.