search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

OASP4J 2.5.0 database integrations issue #635

Closed vapadwal closed 6 years ago

maybeec commented 6 years ago

@sjimenez77 @vapadwal this should go into the bugfix release, shouldn't it? Please note such crucial things in the comments to make it easy for the release manager to finally bring it onto the right branches. As we are starting to establish more dedicated component responsibilities, we should not provide PRs with implicit communication over offline channels.

sjimenez77 commented 6 years ago

I fully agree with @maybeec. Please @vapadwal elaborate a bit more the description of this PR. Thanks!

hohwille commented 6 years ago

So 2.5.0 has already been released. http://repo1.maven.org/maven2/io/oasp/java/modules/oasp4j-jpa/2.5.0/

If we are actually planning a bugfix release for that, this should actually be 2.5.1 - right? I will create branch and milestone then.

hohwille commented 6 years ago

Travis failed with:

[INFO] Caused by: java.lang.UnsupportedClassVersionError: org/springframework/boot/maven/RepackageMojo : Unsupported major.minor version 52.0

So for some strange reason travis uses a new version of spring-boot-maven-plugin without any change from us related to that. This is the same error that I had with #629 and fixed by adding the plugin to the dependency-management of the archetype pom. @vapadwal could you cherry pick my fix from #629 (you can manually copy it - see https://github.com/oasp/oasp4j/pull/629/commits/dfe298e3d6c91e28d756e029d1bc7f3f4137657b) to your fork please.

vapadwal commented 6 years ago

@hohwille thanks for reviewing my PR, I have few questions,

  1. For bugfix release my understanding is we should release from 2.5.1 and after release is done then merge 2.5.1 to master and develop.
  2. There are few commits other than mine one, do we need those fixes also e.g. fixes from mathieu-lavigne
  3. If we are not including fixes from mathieu-lavigne. Should I close this PR and create new one that would only contain 2 fixes 1} spring-boot-starter-data-jpa and 2)fixes for travis spring-boot-maven-plugin.
  4. For fix of travis, I have put spring-boot-maven-plugin in oasp4j/pom.xml and in templates/server/src/main/resources/pom.xml
vapadwal commented 6 years ago

Added the label invalid and discontinued as this PR is not required, its already taken care in release 2.6.0 Closing this PR