search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Wrong OASP4J version in template/archetype #654

Closed AbhayChandel closed 6 years ago

AbhayChandel commented 6 years ago

Currently OASP4J version in template/archetype-resources is 2.6.0 should be 2.6.1-SNAPSHOT.

hohwille commented 6 years ago

OK, I guess you are talking about this one: https://github.com/oasp/oasp4j/blob/develop/templates/server/src/main/resources/archetype-resources/pom.xml#L14

We should instead use a variable for this so we do not have to maintain that redundantly and forget it again in the future.

AbhayChandel commented 6 years ago

@hohwille this project is not part of oasp4j inheritance tree hence cannot use the variables defined in oasp4j. Values required have been set explicitly in this project.

AbhayChandel commented 6 years ago

fixed in #652.

hohwille commented 6 years ago

I will provide a PR that fix this issue in a way that we do not have to maintain the version redundantly anymore and will prevent further problems with this.

hohwille commented 6 years ago

Fixed with PR #656.