search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

oasp4j-jpa compatiblity for DAO with paging support #669

Closed hohwille closed 5 years ago

hohwille commented 5 years ago

oasp4j-jpa shall provide legacy support and compatibility for previous usage scenarios and projects on top of oasp4j-jpa-dao. However, at the moment a refactoring of existing code is required to use LegacyDaoQuerySupport as a kind of shim to retain old functionality.

It would be great if oasp4j-jpa could still contain the DAO classes in the same package namespace but extend from classes in oasp4j-jpa-dao that therefore have to use a new namepsace (different name and/or package). Then the DAO classes could provide the removed methods directly and would retain full API compatibility.

hohwille commented 5 years ago

@vapadwal could you try to solve this on a fork/feature-branch. If all works out, please provide PR. Otherwise lets discuss problems or consider this for https://github.com/devonfw/devcon/issues/135

hohwille commented 5 years ago

So we now have 3 different PRs as implementation for this issue:

hohwille commented 5 years ago

Community voted for PR #675 which is now merged, hence closing this issue.