search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Angular 6 template fails as it uses GET method of login #672

Closed vapadwal closed 6 years ago

vapadwal commented 6 years ago

LoginController#login in the application template has @RequestMapping(value = "/login*", method = RequestMethod.GET) which fails* with the Angular 6 template as this uses POST for login

Changes required in LoginController RequestMapping(value = "/login**", method = { RequestMethod.POST })

ivanderk commented 6 years ago

This might break existing code on the client side as people might had to change their client in order to send a GET request. Why not supporting both?

RequestMapping(value = "/login**", method = { RequestMethod.GET, RequestMethod.POST})

hohwille commented 6 years ago

@ivanderk thanks for your smart suggestion :)

hohwille commented 6 years ago

PR #678 was merged, hence done.