search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Spring boot upgrade issue for mysql #674 #677

Closed Rohit90700 closed 5 years ago

Rohit90700 commented 5 years ago

PR for issue discussed in PR #674 The original bug is: https://hibernate.atlassian.net/browse/HHH-11014 and came via hibernate update to 5.2 triggered by spring-boot upgrade to 2.0

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

hohwille commented 5 years ago

I could not find some option easily but maybe someone else will double check: https://docs.jboss.org/hibernate/orm/5.2/userguide/html_single/Hibernate_User_Guide.html#configurations-mapping

hohwille commented 5 years ago

I finally found the solution we are looking for: https://stackoverflow.com/questions/13062759/can-i-change-default-auto-value-for-generationtype-in-generatedvalue-for-pers That means we can add an orm.xml to our application template that (at least for MySQL via velocity switch) can define the preferrred generated-value strategy.

hohwille commented 5 years ago

BTW: I suggested to create a bug issue first and then a PR to fix it. If I now would create a new PR for the suggested solution there is currently no common bug issue. So in case you create a new PR please also create a bug issue and link both PRs from there (and ideally commit messages with the bug).

vapadwal commented 5 years ago

I have created a separate PR https://github.com/oasp/oasp4j/pull/679, so we can close this PR

hohwille commented 5 years ago

This PR is replaced by PR #679. Thanks for your input what partially was taken over for #679.