search

oasp / oasp4j

The Open Application Standard Platform for Java
Apache License 2.0
60 stars 303 forks source link

Bug with context-path after upgrade to spring-boot 2.0 #683

Open hohwille opened 5 years ago

hohwille commented 5 years ago

After #620 spring boot properties have changed. So here: https://github.com/oasp/oasp4j/blob/a2b1bb1730e0e126061b2fd0a313cac67697a9e0/modules/service/src/main/java/io/oasp/module/service/common/impl/discovery/ServiceDiscovererImplConfig.java#L32 the property server.context-path has to be changed to server.servlet.context-path. Otherwise the context path will not be properly detected with recent spring-boot and therefore local REST tests may fail.

vapadwal commented 5 years ago

I think we need to change in the below files also https://github.com/oasp/oasp4j/blob/develop/templates/server/src/main/resources/archetype-resources/core/src/main/resources/application.properties#L9

https://github.com/oasp/oasp4j/blob/develop/templates/server/src/main/resources/archetype-resources/core/src/main/resources/config/application.properties#L9

maybeec commented 5 years ago

when are you able to release that, as it is currently blocking my project

vapadwal commented 5 years ago

we have raised PR https://github.com/oasp/oasp4j/pull/692 for this