Added a growl warning when user has no access for the state

oasp / oasp4js

OASP4JS deprecated repository

Apache License 2.0

9 stars 161 forks source link

Added a growl warning when user has no access for the state #68

Open tomaszwawrzyniakit opened 9 years ago

oasp-ci commented 9 years ago

Can one of the admins verify this patch?

dumbNickname commented 8 years ago

Hi,

I had a look at the changes and there is a small thing bothering me. The code itself look fine, but do we want to make security module depend on modules such as 'angular-growl' and 'oasp.oaspI18n'? Security module has some good defined and enclosed functionality. What if somebody wants to use this module but he/she would like to handle access denied warnings in a different way (not growl messages)? I would suggest to keep the module hermetic.

Cheers, Bartek

Devonfw-ci commented 7 years ago

Can one of the admins verify this patch?

CLAassistant commented 5 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}