Clarify what must be done on existing transfers when a trade is updated. In particular, define what must be done on transfers linked to a product and not a trade (ex: coupons, dividends...).
If such transfers amount is nulled after trade update, should it be canceled or deleted ?
Consider also the case where a new trade is created in the sell direction; indicate what must be done on existing product based transfers with amount nulled after this trade.
Once defined, ensure to have the model documented and implemented (Review TransferManager classes for all product based trades).
Clarify what must be done on existing transfers when a trade is updated. In particular, define what must be done on transfers linked to a product and not a trade (ex: coupons, dividends...). If such transfers amount is nulled after trade update, should it be canceled or deleted ? Consider also the case where a new trade is created in the sell direction; indicate what must be done on existing product based transfers with amount nulled after this trade. Once defined, ensure to have the model documented and implemented (Review TransferManager classes for all product based trades).