oasys-elettra-kit / OASYS1-Wiser

The implementation of WISER into OASYS
MIT License
0 stars 1 forks source link

Making WISER work for everyone #63

Open capitanevs opened 3 years ago

capitanevs commented 3 years ago

TEST FILE1# "MARGOT 3" Notice

test_margot_03_READONLY.LOG

maltissimo commented 3 years ago

By opening the file test_margot_03_READONLY.ows (attached), both Oasys 1.2 and 1.3 give some errors. In particular:

Errors occurred while opening workflow:

UnknownWidgetDefinition('orangecontrib.wiser.widgets.light_sources.ow_gaussian_source_1d.OWGaussianSource1d') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_detector.OWDetector') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_slit.OWSlits') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')

By clicking OK on the Errror window I get:

CodeGenerated from Branch1

from LibWiser.EasyGo import* Gaussian_Source =LibWiser.Foundation.OpticalElement( Name = 'Gaussian Source', IsSource = True, CoreOpticsElement =LibWiser.Optics.SourceGaussian( Lambda = 2.000000e-08, Waist0 = 1.273240e-04, M2 = 1.000000e+00, AnglePropagation = 0.000000e+00, Orientation = OPTICS_ORIENTATION.ANY, ), PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'absolute', PlaceWhat = None, PlaceWhere = None, GrazingAngle = None, Distance = None, ), ) Slit =LibWiser.Foundation.OpticalElement( Name = 'Slit', IsSource = False, CoreOpticsElement =LibWiser.Optics.Slits( L = 5.000000e-03, AngleGrazing = 9.000000e+01, Orientation = OPTICS_ORIENTATION.ANY, ), PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'source', PlaceWhat = 'centre', PlaceWhere = 'centre', GrazingAngle = None, Distance = 9.700000e+01, ), ) Elliptic_mirror =LibWiser.Foundation.OpticalElement( Name = 'Elliptic mirror', IsSource = False, CoreOpticsElement =LibWiser.Optics.MirrorElliptic( L = 3.000000e-01, Alpha = 0.04363323129985824, f1 = 9.900000e+01, f2 = 1.400000e+00, Orientation = OPTICS_ORIENTATION.ANY, ), PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'source', PlaceWhat = 'centre', PlaceWhere = 'centre', GrazingAngle = None, Distance = 9.900000e+01, ), ) Detector =LibWiser.Foundation.OpticalElement( Name = 'Detector', IsSource = False, CoreOpticsElement =LibWiser.Optics.Detector( L = 2.000000e-04, AngleGrazing = 1.5707963267948966, Orientation = OPTICS_ORIENTATION.ANY, ), PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'upstream', PlaceWhat = 'centre', PlaceWhere = 'centre', GrazingAngle = None, Distance = 1.400000e+00, ), ) WiserBeamline = BeamlineElements([Gaussian_Source, Slit, Elliptic_mirror, Detector]) WiserBeamline.RefreshPositions()

(see attached image)

Also, the figures have some issues, see attached images screenshot

Issue 63 files .zip

capitanevs commented 3 years ago

Comment:

all the part below seems to be nothing but the text contained in the comment box. I do not really know what it could mean...

@aljosahafner , how can we go bug-hunt?

CodeGenerated from Branch1

from LibWiser.EasyGo import* Gaussian_Source =LibWiser.Foundation.OpticalElement( Name = 'Gaussian Source', IsSource = True, CoreOpticsElement =LibWiser.Optics.SourceGaussian( Lambda = 2.000000e-08, Waist0 = 1.273240e-04, M2 = 1.000000e+00, AnglePropagation = 0.000000e+00, Orientation = OPTICS_ORIENTATION.ANY, ), PositioningDirectives =LibWiser.Foundation.PositioningDirectiv

aljosahafner commented 3 years ago
UnknownWidgetDefinition('orangecontrib.wiser.widgets.light_sources.ow_gaussian_source_1d.OWGaussianSource1d')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_detector.OWDetector')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_slit.OWSlits')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')

This seems to me like a problem with Wiser installation...

capitanevs commented 3 years ago

Yes, I agree with you. Matteo just installed OASYS1-Wiser add on. What could be wrong? Is there any file/folder to check to see wether the package has been properly installed? Any hint?

Inviato da myMail per Android Venerdì, 10 Settembre 2021, 11:25AM +02:00 da aljosahafner @.*** :

UnknownWidgetDefinition('orangecontrib.wiser.widgets.light_sources.ow_gaussian_source_1d.OWGaussianSource1d') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_detector.OWDetector') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_slit.OWSlits') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror') UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')

This seems to me like a problem with Wiser installation... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or unsubscribe . Triage notifications on the go with GitHub Mobile for iOS or Android .

aljosahafner commented 3 years ago

Our version is called OASYS1-Oasyswiser . The other one is the old one.

capitanevs commented 3 years ago

Great shot!

Matteo, the right add-on is "OASYS1-Oasyswiser", not the one I told you.

Aljosa, can we remove all the old versions from PyPy?

Tnx guys,

Michele

Can we take the moment to remove

Il 10/09/2021 14:43, aljosahafner ha scritto:

Our version is called OASYS1-Oasyswiser . The other one is the old one.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oasys-elettra-kit/OASYS1-Wiser/issues/63#issuecomment-916875595, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGPG3A4TRZGDHX67KTG3OLUBH4NVANCNFSM5DY3LQ3Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. Web Bug from https://github.com/notifications/beacon/ADGPG3C5WO44BZVURBP3JUDUBH4NVA5CNFSM5DY3LQ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG2TGSSY.gif

-- Michele Manfredda, PhD Scientist Photon Transport Group Elettra - Sincrotrone Trieste (IT)

"The release date is just one day, but the record is forever." Bruce Springsteen

aljosahafner commented 3 years ago

If you mean OASYS1-Wiser, then no, because I am not a maintainer of the repository.

capitanevs commented 3 years ago

ok, I'll get the rights for us. Looking at the naming- OASYS1-WISER (all capitol) would be the best name for our package. How much does it cost to rename/duplicate the package with thia new name (and delete all the dead bramches)?

Inviato da myMail per Android Venerdì, 10 Settembre 2021, 03:44PM +02:00 da aljosahafner @.*** :

If you mean OASYS1-Wiser, then no, because I am not a maintainer of the repository. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or unsubscribe . Triage notifications on the go with GitHub Mobile for iOS or Android .

aljosahafner commented 3 years ago

If we get rights for OASYS1-Wiser, then it's ok, but otherwise I'd like to avoid any kind of renaming because it will introduce a lot of problems. AFAIK Luca doesn't like all capital letters...