oasys-elettra-kit / OASYS1-Wiser

The implementation of WISER into OASYS
MIT License
0 stars 1 forks source link

IGNORE => Is the Gui badly connected? (Yes) #72

Closed capitanevs closed 2 years ago

capitanevs commented 3 years ago

Also here, it seems that the gui and the internal representation of the beamline do not match.

Can you please do a round check of all the controls of the GUI and check that they properly send their data to LibWiser?

immagine

Hint:use the GetBeamline python script to check.

capitanevs commented 3 years ago

If the slit is NOT ignored, then a detectorplaced downstream will show a diffraciton pattern immagine

If the slit is IGNORED, then a detector will just show the propagated gaussian intensity from the source

immagine

We are physicist,not programmers :-) Let's check physics, too...

aljosahafner commented 3 years ago

Ignore option works in the following way: libWiserOE.CoreOptics.ComputationSettings.Ignore = (self.ignore == 1)

capitanevs commented 2 years ago

It's wrong

There is no Ignore attribute into CoreOptics.ComputationSettings

Use libWiserOE.ComputationSettings.Ignore, instead.

aljosahafner commented 2 years ago

I am already using

libWiserOE.ComputationSettings.Ignore

image

capitanevs commented 2 years ago

Nope, you are using libWiserOE.CoreOptics.ComputationSettings.Ignore while the correct one is libWiserOE.ComputationSettings.Ignore

:-)

aljosahafner commented 2 years ago

You're right, my bad :D I'll proceed with updating immediately

capitanevs commented 2 years ago

The Rationale "should" be that: OpticalElement is about how an optical elements is seen from the ecosystem and it iteracts with it.

CoreOptics, covnersely, just concerns the specific behavior of the optical element, in an isolated way.

That's why Ignore is in OpticalElement: it concerns the propagation.

Clearly, all these are "faint guidelines", and not at all "iron-carved- rules" :D

I should have created a unique ComputationSettings, I know

aljosahafner commented 2 years ago

I think it's ok... 0.3.18 should have it the proper way.

capitanevs commented 2 years ago

Let's close it.