oasys-elettra-kit / OASYS1-Wiser

The implementation of WISER into OASYS
MIT License
0 stars 1 forks source link

Capture the generical error on oasys widget #74

Open capitanevs opened 2 years ago

capitanevs commented 2 years ago

The two branches are supposed to be equal, but they return different results.

a) "kbh dpi" of branch A, generate an error, and GetBeamlineInfo return some results. These results are not consistent with what is pecified in "kbh dpi". This behavior is strange.

b)"kbh dpi" of branch A, generate an error, and GetBeamlineInfo, if executed independently, also cast an error, as there is no input signal. This behavior is as expected.

What to do

immagine

aljosahafner commented 2 years ago

Yes, after reading a bit around this is perfectly fine behaviour. I will make the two try: except: statements and let the code continue executing even if the wavefront can't be calculated.

capitanevs commented 2 years ago

Great!

aljosahafner commented 2 years ago

I implemented this, can you share a workspace where the wavefront can't be calculated, but the beamline is fine?

capitanevs commented 2 years ago

To Be Continued