search

oasys-kit / shadow3

Official repository for shadow3 (x-ray-tracer engine)
MIT License
31 stars 19 forks source link

Failure to compile in fedora (using gcc/gfortran 8) #35

Closed srio closed 2 years ago

srio commented 5 years ago

with gfortran 8 the compilation of shadow_variables.f90 (and others) fails with the following error:

Error: Component 'file_xxx' of BIND(C) type at (1) must have length one

This is a change of behaviour in the char C/Fortran interface. See:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84885

See also this discussion:

https://sourceforge.net/p/wsjt/mailman/message/36262831/

srio commented 3 years ago

This has been solved some time ago by Tom Schoonjans. Thanks a lot Tom.

The changes are not yet included in the master. In the meantime, you can use Tom's version doing: 

git clone https://github.com/PaNOSC-ViNYL/shadow3.git

cd shadow3

git checkout gfortran8-fixes
srio commented 2 years ago

This is fixed in shadow3 22.8.20