search

oat-sa / lib-lti1p3-core

PHP library for LTI 1.3 Core implementations as platforms and / or as tools.
GNU General Public License v2.0
33 stars 16 forks source link

Support for version 4.2.0 of lcobucci/jwt #150

Closed Graspleric closed 2 years ago

Graspleric commented 2 years ago

Hi there,

The 4.2.0 version of lcobucci/jwt does not allow you to create an empty InMemory-key anymore using InMemory::plainText(''). Using this construct now results in an exception, breaking different flows through this library.

This PR solves this issue by using the dedicated method to create such an empty key. There is some more code needed to make sure the code also works with the PHP 7 branches (as they depend on an older version of the library).

Please let me know if you need any additional information or tests.

wazelin commented 2 years ago

Thank you for the PR.

The issue should be now resolved by https://github.com/oat-sa/lib-lti1p3-core/releases/tag/6.7.2